Make 'build against installed ffmpeg' the default build strategy #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the "default" build strategy of torchcodec:
We are removing the
BUILD_AGAINST_INSTALLED_FFMPEG
env variable and introducing insteadBUILD_AGAINST_ALL_FFMPEG_FROM_S3
.I think there's a pretty low risk that binaries get built without settting
BUILD_AGAINST_ALL_FFMPEG_FROM_S3=1
. We'll add a battery of sanity checks as we build the distribution packages to make sure that never happens.This is a follow-up to this review comment: https://www.internalfb.com/diff/D58527965?dst_version_fbid=262903956885891&transaction_fbid=981479793448363